- Jun 06, 2014
-
-
Keisuke Kuroyanagi authored
Bug: 13142176 Bug: 15428247 Change-Id: I5c23fbea2851f891f76f19d9da2cb70ae964569b
-
Keisuke Kuroyanagi authored
Bug: 13142176 Bug: 15428247 Change-Id: I5be6d683be95505412615ca7c88260de1ea05f54
-
Tadashi G. Takaoka authored
Change-Id: I51c5247ac925a158facb79057f704b763b903552
-
Tadashi G. Takaoka authored
Change-Id: I849cec7deb5607e8ce8fb25c1f903f15328fb611
-
Jean Chalard authored
The symptom : when text is selected and the device is rotated, sometimes the keyboard sets the word as being composed around the start of the selection. Upon the next rotation this ends up with the keyboard committing some text in place of the selection. The cause : another bug in the framework with rotation >.> The keyboard receives a call to startInput with a wrong cursor position, namely one that does not represent a selection. The keyboard sets a composition according to this wrong data. When the keyboard is rotated again, it commits the text, which takes the place of the selection. The solution : actually when restarting input the keyboard realizes that the cursor position is wrong. We cancel composition at that time. For robustness, this change also implements two other defensive changes : upon call to onUpdateSelection, we actually realize that the previous values were wrong, so we also fix it at that time, and in addition, when rotating, we finishComposingText() instead of commitText() which is less dangerous. Implementing this later change also allows us to let less internal variables from InputLogic escape to LatinIME, so it's also a good change for design. Bug: 14140799 Change-Id: Ib10de18e53e376ac1bbc8487e13d969828483346
-
- Jun 05, 2014
-
-
Keisuke Kuroyanagi authored
Bug: 13142176 Bug: 15428247 Change-Id: I93b44ef40cafb6b811c68fa79f3a4971fc3916a5
-
Tadashi G. Takaoka authored
Change-Id: I434cf507e68349b9893ac084645986d6b3d7da91
-
Keisuke Kuroyanagi authored
Bug: 13142176 Bug: 15428247 Change-Id: I2ae25090b67ad0c6df97dec7712e2f7e0bb08c40
-
Tadashi G. Takaoka authored
Change-Id: I4f13e85a3db1ba4adf36c596cb23827bdcf93ae7
-
- Jun 04, 2014
-
-
Tadashi G. Takaoka authored
Bug: 12491371 Change-Id: Ib01452b6a2a53faa591b05e62014f356e0511308
-
Tadashi G. Takaoka authored
Bug: 12491371 Change-Id: Ib1fc8affbccfbaca3424ecdc2812f47047106aa2
-
Jean Chalard authored
Bug: 13869301 Change-Id: Icd77a308f85cc16dccffe65a532471c738d6fbc5
-
Tadashi G. Takaoka authored
Bug: 12491371 Change-Id: I8c5b1e91f41146a023edcc405e6120c0bf33f49b
-
Jean Chalard authored
Bug: 13283555 Change-Id: Iab0466425dc44779d110f2cd29d725d22eb04827
-
Jean Chalard authored
Rename `initialize' to `start' and `deactivate' to `stop' for ease of understanding. It's completely bizarre that you can "deactivate" a recapitalization and that will just restart a new one the next time you press shift. Start and stop are easier to understand. Change-Id: I455175aebfcfe11198c6c61bf2c6b19efc3f82df
-
Tadashi G. Takaoka authored
It turns out passing hover event to accessibility key handling methods isn't necessary. This parically reverts I1f7feef707. Bug: 12491371 Change-Id: I9d71cd29723344433427795e44cb22ac41faace6
-
Yohei Yukawa authored
BUG: 14324207 Change-Id: Idc8582655bc73cb24e416e8ba78470209b2ff702
-
- Jun 03, 2014
-
-
Tadashi G. Takaoka authored
This CL reorders keys around the spacebar. - On phone's symbols and symbols shift layout, the comma key is moved to the left of the spacebar to aligned with main layout. - On tablet's layout, the comma key is moved to the left of the spacebar on all layout to aligned with the same layout of phone's. Also the comma key has "settings" as more keys. - In Arabic and Perisan, the comma key of tablet already has some more keys This CL remove "/" and add "settings" instead. Bug: 15281451 Change-Id: I6e0e75e4d4abfb1f356e7499be91424c7c57c58b
-
Tadashi G. Takaoka authored
Change-Id: I2cba2bb5b2f449ed29895365b9c6ca285a7640fe
-
Tadashi G. Takaoka authored
KeyboardAccessibilityDelegate.synthesizeTouchEvent() wrongly passed pointer's id as a 6th argument of MotionEvent.obtain method that should be metaState. Change-Id: I822f9647a1ba27ee8cee39f373f6a1c003ebf665
-
Tadashi G. Takaoka authored
Change-Id: I913ec290ddfd0ae4cc6e600ba95b7442167f0989
-
Tadashi G. Takaoka authored
Change-Id: I0ef983f54e828193e9c7e4a10c888f72702d499c
-
- Jun 02, 2014
-
-
Tadashi G. Takaoka authored
Change-Id: I4cbae476d16723778b46ff765dd97832f279785f
-
Jean Chalard authored
Bug: 14602663 Change-Id: Ie2060931df911b44230d5a5ba268f687cbdd0dc8
-
Tadashi G. Takaoka authored
Bug: 12491371 Change-Id: I1f7feef707b95e8862db71cbc4f6f5585a2441dd
-
Tadashi G. Takaoka authored
Bug: 13336905 Change-Id: Iefd117fa7b30b8ba240590b13b03d7044fd37ede
-
Tadashi G. Takaoka authored
Bug: 12491371 Change-Id: Ib7ca91ae73aa40e45ea5f6d4e53348a261a4b823
-
Tadashi G. Takaoka authored
Bug: 12491371 Change-Id: I3ce1e6557e41a94146b882751f75ae4b5f6bc73d
-
- May 30, 2014
-
-
Tadashi G. Takaoka authored
Bug: 15321822 Change-Id: Iab7cef83ffdf91c877c3ed2e59d412496b516e1c
-
Keisuke Kuroyanagi authored
This fixes PunctuationTests# testAutoCorrectionWithSingleQuotesAround. Bug: 14119293 Bug: 15334309 Change-Id: I604c21a21e89a5fc431fd56ab7b6ad03f4736b01
-
Jean Chalard authored
At 100k text, it's reasonably fast (less than 1s on latest hardware). Bug: 12913404 Change-Id: I426b918b2610af24364934a1c37a7314f1142ad0
-
- May 29, 2014
-
-
Tadashi G. Takaoka authored
Bug: 15321822 Change-Id: I6a5a865364fb98e0ebb6206d80d5629bbcb817b8
-
Tadashi G. Takaoka authored
This CL must be checked in together with Ie52007dc5c. Bug: 15318007 Change-Id: Ie665f296e43b5485ae8ba7e949aa262794ee0dcc
-
Jean Chalard authored
This reverts commit d941ea18 and builds on it to fix the behavior of the broken cases. It also fixes a small, related bug that probably has existed for a very long time: predictions not displayed when cancelling double-space-to-period. Bug: 15148015 Change-Id: I1f9358f8b6f5804f831643611576be347e83999d
-
Keisuke Kuroyanagi authored
Bug: 15320560 Change-Id: Icb88a96ebd685da1d2cba7b07889a2751c603a2e
-
Tadashi G. Takaoka authored
This CL must be checked in together with I5cc76807e3. Bug: 15318007 Change-Id: I61423c3377ddc299fb332e742d6626c2e47145bb
-
Keisuke Kuroyanagi authored
Bug: 15298959 Change-Id: I6921db77b7d231ad3aad99d4c380ae2ed6bbf540
-
- May 28, 2014
-
-
Keisuke Kuroyanagi authored
Bug: 15298959 Change-Id: Iba6eeb7981634e7ddb896404978b30f6efd6e72f
-
Tadashi G. Takaoka authored
This CL must be checked in together with I6fd87e1eec. Change-Id: I4b24157f3e3ce6327579d37122a34d7a30069885
-
Tadashi G. Takaoka authored
This CL also adds visual feedback of hovering key in accessibility mode. Bug: 12491371 Change-Id: I7b1f28a2e421ca60b2738ed94e7bdb406f75039b
-