Skip to content
Snippets Groups Projects
  1. Jun 05, 2013
  2. Jun 04, 2013
  3. Jun 03, 2013
  4. May 28, 2013
  5. May 24, 2013
  6. May 22, 2013
  7. May 15, 2013
  8. May 14, 2013
  9. May 13, 2013
  10. May 10, 2013
  11. May 02, 2013
  12. May 01, 2013
  13. Apr 22, 2013
  14. Apr 16, 2013
    • Jean Chalard's avatar
      Don't insert automatic spaces when text looks like a URL · 73ec85b8
      Jean Chalard authored
      This is about as ad-hoc as it gets, but then again, what we want
      is probably as ad-hoc as it gets.
      All URL boxes I know of double as search bars, and not adding
      automatic spaces there sucks (e.g. in Chrome URL bar).
      And in other boxes actually you don't want to add a space if
      it looks like a URL. QSB isn't even a search box, and it behaves
      like this.
      
      So I think this is actually the right answer to the problem.
      
      Bug: 7062925
      Change-Id: Ib09472b34644fd5bf2dc84bb97cedeeba28bcd02
      73ec85b8
    • Jean Chalard's avatar
      Match the keyboard state to the recapitalize state. · 8094bf45
      Jean Chalard authored
      Bug: 7657025
      Change-Id: I2f8fe7fc4596a498322ba5ccabbd0c18a2bc36cf
      8094bf45
    • Jean Chalard's avatar
      Clean up RecapitalizeStatus · b794e904
      Jean Chalard authored
      Change-Id: Ib4d002f90cd3a0e9ad4c04b883b0c1f05ada3ccf
      b794e904
  15. Apr 15, 2013
    • Jean Chalard's avatar
      Remove a useless function · bc501647
      Jean Chalard authored
      Bug: 8583091
      Change-Id: I9195d68e44e9a282e25ccd2978d7b4088f600170
      bc501647
    • Jean Chalard's avatar
      Have Latin IME re-capitalize a selected string · 2995abe7
      Jean Chalard authored
      Upon pressing Shift, if there is currently a selected string, have
      Latin IME change its capitalization.
      This does not yet have the keyboard mode follow the mode - the change
      is complicated enough as is.
      
      Bug: 7657025
      Change-Id: I54fe8485f44e04efd72c71ac9feee5ce21ba06f2
      2995abe7
    • Jean Chalard's avatar
      If there are no suggestion span, recompute suggestions. · 0e9ee4d3
      Jean Chalard authored
      Bug: 8084810
      Change-Id: I1743c09c43ca6835bb2f607684b037bf17d36335
      0e9ee4d3
    • Jean Chalard's avatar
      Clean up tests and increase speed · 001884a1
      Jean Chalard authored
      Conservatively reduce the number of unigrams to test from 1000
      to 100.
      
      Bug: 8583091
      Change-Id: I48621ec44ff5f0590640d7c6b174ab5a6d267aaf
      001884a1
    • Jean Chalard's avatar
      Fix a typo · c2653d0b
      Jean Chalard authored
      Change-Id: I27b925be030e9e6ee8ae49dc13f39accec996d7e
      c2653d0b
    • Jean Chalard's avatar
      Fix Binary dict tests · c2e9c511
      Jean Chalard authored
      There are two problems here. The first one is the tests would send
      an invalid unicode character. Although we could want dicttool to
      handle this more gracefully, it's fine for now.
      
      The second problem is much more serious. If a node has more than
      128 children, then the java code will crash trying to read the
      dictionary back because of a bug that this change fixes. In
      theory, it's possible that happens when we try to load the user
      history dictionary back from the disk - native code is not affected
      so there is no other point that may cause a problem.
      In the practice, that means you'd need to have 129 words with a
      common prefix (including empty string) but all different after
      this. It's almost impossible with Google Keyboard since there are
      only so many keys on the keyboard that you can make a word out
      of, and then again you'd have to do it repeatedly until it
      actually enters the user history dictionary, wait for it to get
      saved on the disk.
      The bad news is, if you manage to get this far, the keyboard will
      crash every time and won't be able to get up until you clear
      data for the package.
      The good news is, the dictionary itself is not corrupted and only
      the reading code is wrong. So updating to a newer version would
      actually even recover from this situation.
      
      All in all, considering how almost-impossible this is to trigger,
      I don't think even a single user actually did hit this bug.
      
      Bug: 8583091
      Change-Id: Iabb2a7f47cbd9ed3193d2a3487318d280753e071
      c2e9c511
    • Tadashi G. Takaoka's avatar
      Tighten unit test condition of MoreKeysKeyboardBuilder · b12c2af3
      Tadashi G. Takaoka authored
      Bug: 8601979
      Change-Id: Icf584f3b35adce69cc3dfc46f3aacfef05e5dd2a
      b12c2af3
  16. Apr 12, 2013
    • Jean Chalard's avatar
      Fix failing tests · 128961ad
      Jean Chalard authored
      RichInputConnection#getWordRangeAtCursor may now returning
      either a SpannableString or a String. We can't test that with
      String#equals(), but TextUtils#equals() does the job for us.
      
      Change-Id: I59ebe54207e92f4d90b49476b64f1e12fd4929cb
      128961ad
    • Jean Chalard's avatar
      Remove voodoo magic. · d89ed476
      Jean Chalard authored
      There was a much, much simpler way of achieving the same thing.
      
      Bug: 8583091
      Change-Id: I8882f389312caad3b17335672892a31d30cd00bc
      d89ed476
  17. Apr 11, 2013
  18. Apr 10, 2013
Loading