Skip to content
Snippets Groups Projects
  1. Jan 26, 2012
  2. Jan 13, 2012
    • Tadashi G. Takaoka's avatar
      Fix SuggestTests · 9c735b80
      Tadashi G. Takaoka authored
      We need revised scoring test because dictionary look up algorithm has
      been changed significantly since this SuggestTests was made.
      
      Change-Id: I69d527a6bfa24ed0dc189fddad1afab0566c6eb8
      9c735b80
  3. Dec 09, 2011
    • Jean Chalard's avatar
      Stop a flag from escaping. · 4606de11
      Jean Chalard authored
      The ultimate intent is to close it up in the settings, as it does not
      change while typing, only when the keyboard is open again.
      
      Change-Id: I12ff56e7482c1584877fe5531473bf03e95a60f6
      4606de11
  4. Dec 08, 2011
  5. Nov 29, 2011
  6. Nov 21, 2011
    • Jean Chalard's avatar
      Special case quotes at start and end of words · c83359f9
      Jean Chalard authored
      Single quote at start of word is not considered a part of a
      word any more.
      Single quote at the end of a word now behave like capitalization:
      lookup in the dictionary is done *disregarding* a final quote,
      and it is forcefully added back into the suggestions afterwards.
      
      Bug: 5566368
      Change-Id: I14dd3815f4b743edba56d64a3abdf4b73d863a6a
      c83359f9
  7. Oct 28, 2011
  8. Oct 07, 2011
  9. Oct 06, 2011
  10. Oct 03, 2011
  11. Sep 15, 2011
    • Jean Chalard's avatar
      Avoid returning an object that's still used internally · 5c08151c
      Jean Chalard authored
      There is no definite path known for this to end up being
      touched by other classes, but we could imagine through
      some way or some other it ends up shoved in the stringbuilder
      pool, leading to catastrophic results.
      
      Hopefully related to
      Bug: 5248688
      
      Change-Id: Ib8abfc31263cbf31d515ed607ced5d8253971938
      5c08151c
  12. Sep 01, 2011
    • Jean Chalard's avatar
      Fix a bug where autotext would occasionally not work · 358e1327
      Jean Chalard authored
      Autotext correction would check whether the first suggestion
      so far was the same as what Autotext would return, and if it
      was indeed the same, would not send its result as
      autocorrect. However, the first suggestion is not guaranteed
      to have a high enough score to trigger autocorrection, and
      there would be cases where a word in autotext would not get
      autocorrected because the word came out of bigram
      suggestions. These occurrences would be extremely rare, as
      they would require concomitant insert between autotext for
      one char and bigram suggestion. It is, in fact, probably
      limited to the capitalization of "I".
      
      This did not happen in gingerbread because gingerbread would
      not register 1-letter words as valid bigrams.
      
      This fix works by just always sending the result of autotext
      regardless of whether it is already the first suggestion or
      not. This is okay because duplicates are removed afterwards
      anyway - and this processing is absolutely necessary because
      the autotext'd word may actually be somewhere else in the
      suggestion, so it made really no sense checking for only the
      first one.
      
      Please note that there is also a race condition that can
      result in "i" not being converted to "I": at the moment,
      Latin IME relies on having the suggestions evaluated
      at the time autocorrection is performed, but when typing
      very, very fast, those messages may have been canceled.
      This is not limited to the autocorrection of "i", but
      affects all autocorrections. It requires a nearly
      inhumane typing speed to trigger, but hitting "i" and
      space in turn as fast as one can it's possible to
      reproduce occasionally.
      
      Bug: 5135113
      Change-Id: I530ea6212487300001a2c0fc5b25a5c7716bdf63
      358e1327
  13. Aug 23, 2011
    • Jean Chalard's avatar
      Fix a bug with the string pool. · a6e912cf
      Jean Chalard authored
      This also adds some optional debug code to detect more easily possible
      future occurrences of the same problem.
      
      Bug: 5195017
      Change-Id: I2558b468e46f7090de868f1ec2dc9e24895d670f
      a6e912cf
  14. Aug 19, 2011
  15. Aug 18, 2011
  16. Aug 09, 2011
    • Jean Chalard's avatar
      Stop reloading contacts when not appropriate. · 14051e2b
      Jean Chalard authored
      A recent change had the contacts reloaded every time a new field
      is touched. This change not only fixes the problem, but also removes
      reloading contacts when changing language, which should make language
      switch within LatinIME lighter.
      
      Bug: 5125034
      Change-Id: Ia61c4f75a8617113cdce88a2e2c6fdf073146a2d
      14051e2b
  17. Aug 08, 2011
  18. Aug 04, 2011
  19. Jul 27, 2011
    • Jean Chalard's avatar
      Load the binary dictionary asynchronously. · 3af9f05f
      Jean Chalard authored
      This should help with LatinIME opening performance.
      It should not be merged before Ia9e4741f (if it is, there is a
      race condition where the wrong dictionary is opened).
      
      Bug: 5023141
      Change-Id: I39c52de70a449929a622dddfdd92b38425ad9416
      3af9f05f
  20. Jul 15, 2011
  21. Jun 21, 2011
  22. Jun 20, 2011
    • Tadashi G. Takaoka's avatar
      Close dictionary appropriately · 3439c726
      Tadashi G. Takaoka authored
      The dictionary that extends ExpandableDictionary must be closed when
      it becomes unused.
      
      Bug: 4725930
      Change-Id: Ib5d2c39771fb7010d303a26d1ea1c8e237c0101f
      3439c726
  23. Jun 14, 2011
    • Tadashi G. Takaoka's avatar
      Implement expandable candidates pane · 86e815a1
      Tadashi G. Takaoka authored
      This change removes horizontal scroll from candidates strip. Instead
      of that this change introduces "fixed 3 items candidates strip" and
      "expandable candidates pane".
      
      Bug: 4175031
      
      Change-Id: Ia367d9074436fdea76d3b653d81798ce2749170e
      86e815a1
  24. Jun 13, 2011
  25. Apr 27, 2011
    • Jean Chalard's avatar
      Create a dictionary collection and a dictionary factory. · 4250eb27
      Jean Chalard authored
      The dictionary collection is a class complying to the Dictionary
      interface that acts as a front end to a collection of arbitrarily many
      dictionaries of any type.
      The dictionary factory is a helper class for creating various
      dictionaries and get some meta information about them.
      
      At the same time, this change makes the BinaryDictionary class
      not a singleton any more.
      
      This also needs I9afe61a9 to not break the build.
      
      Change-Id: I61fdcc4867fcda18342807bf1865e6e46979e5d5
      4250eb27
  26. Apr 26, 2011
    • Jean Chalard's avatar
      Fix Eclipse warnings. · 0c8d5ca0
      Jean Chalard authored
      This change is only there to fix warning issued by Eclipse.
      It should have absolutely no impact on the program logic.
      
      Change-Id: Ie0e242ac6c167297d33de19902340b0f6ecae9e1
      0c8d5ca0
  27. Apr 22, 2011
  28. Apr 21, 2011
  29. Apr 20, 2011
    • Jean Chalard's avatar
      Move language-specific keyboard setting to resources. · c899038e
      Jean Chalard authored
      Some flag settings used to be stored in a keyboard layout extravalue setting. This
      change:
      - Introduces the capability of setting such specific flags in values/config.xml
      - Retains the ability to use extravalues (for layout-specific settings), though
        there is no more any such setting at the moment.
      - Fixes a bug where loading a dictionary from outside does not initialize the flags.
      - Moves Flag to another class.
      
      Note: this needs I705ec68c to avoid breaking the build
      
      Change-Id: Ia7703aae3215b06c0b3cb792821649806e8998c1
      c899038e
  30. Mar 18, 2011
    • Jean Chalard's avatar
      Add different ways of reading the dictionary file. · cba93f50
      Jean Chalard authored
      This change adds basic support for an external dictionary provider.
      It adds methods for reading the dictionary itself from an asset in
      the dictionary provider package directly, obtaining the file name
      through the ContentProvider interface; it also adds a way of getting
      the data through an InputStream and copying the file locally.
      
      Incidentally this change also adds the code needed to listen for
      updating the dictionary provider package and reloading it in time.
      
      This change also goes hand-in-hand with Iab31db6e, which implements
      the small closed part of this.
      
      Issue: 3414944
      
      Change-Id: I5e4fff99a59bb99dbdb002102db6c90e6cb41c8a
      cba93f50
  31. Mar 17, 2011
    • Tadashi G. Takaoka's avatar
      Refactor BinaryDictionary a bit · 071f4714
      Tadashi G. Takaoka authored
      This changes:
      * Flag initialization code in BinaryDictionary to be more unit test friendly.
      * Removing unnecessary class hierarchy of LatinIME inner class WordAlternatives.
      * Formatting normalized score neatly.
      
      Change-Id: I9f10c093d4f36258fe883cf3fb10cbbda2770497
      071f4714
  32. Mar 16, 2011
    • Tadashi G. Takaoka's avatar
      Add Utils.equalsIgnoreCase methods · e7a2512a
      Tadashi G. Takaoka authored
      This change also corrects usage of "frequency", "priority" and "score"
      * Frequency is the relative probability in dictionary.
      * Score is the relative probability in suggestions.
      * Priority is kind a sorted score.
      
      Change-Id: Iafb135a4ecdb401cc505014a07c74dfcac44d699
      e7a2512a
    • Jean Chalard's avatar
      Avoid the removal of high-ranking exactly typed candidates. · d631651b
      Jean Chalard authored
      It used to be the case that the scoring system turns up the same word
      that was entered with a different capitalization, but with a lower
      score than some other, more frequent word. To cope with this, there
      was code that would order such candidates in the first slot no matter
      what. This processing is now useless because fully matching words now
      have a huge boost that ensures they will get to the top of the list,
      before any non-fully matching word (which means, differing only by
      capitalization or accents).
      
      The bug that did happen with this was, if a fully-matching word got
      matched by several processing passes, and the (chronologically) later
      score affected to this word was weaker, it would result in the
      duplicate removal pass removing the stronger score. This in turn would
      mess with autocorrect.
      
      In an effort to keep the risk at a minimum for MR1, this change does
      not actually remove the useless code, but adds a check in the odd case
      to avoid the bad situation. Another change will remove the code for
      ICS release.
      
      bug: 4100269
      
      Change-Id: I18c0575332981ffec0e257e26a360995838d521e
      d631651b
  33. Mar 08, 2011
  34. Mar 04, 2011
  35. Mar 03, 2011
  36. Mar 02, 2011
Loading