Skip to content
Snippets Groups Projects
Commit d426941e authored by Jean Chalard's avatar Jean Chalard
Browse files

Fix a theoretical bug (A12)

If a word is a dictionary word but still has no suggestion,
this method should return true. In the practice, it makes
no difference since a word without suggestion won't be changed
anyway.

Change-Id: Ib1f5ef254b7da7e5cedb2f973529ad431beb93f9
parent 9701b360
No related branches found
No related tags found
No related merge requests found
......@@ -38,8 +38,7 @@ public class AutoCorrection {
final CharSequence whitelistedWord) {
if (hasAutoCorrectionForWhitelistedWord(whitelistedWord)) {
return whitelistedWord;
} else if (shouldAutoCorrectToSelf(
dictionaries, wordComposer, suggestion, consideredWord)) {
} else if (shouldAutoCorrectToSelf(dictionaries, wordComposer, consideredWord)) {
return consideredWord;
} else if (hasAutoCorrectionForBinaryDictionary(wordComposer, suggestion,
consideredWord, autoCorrectionThreshold)) {
......@@ -111,10 +110,9 @@ public class AutoCorrection {
private static boolean shouldAutoCorrectToSelf(
final ConcurrentHashMap<String, Dictionary> dictionaries,
final WordComposer wordComposer, final SuggestedWordInfo suggestion,
final CharSequence consideredWord) {
final WordComposer wordComposer, final CharSequence consideredWord) {
if (TextUtils.isEmpty(consideredWord)) return false;
return wordComposer.size() > 1 && null != suggestion
return wordComposer.size() > 1
&& !allowsToBeAutoCorrected(dictionaries, consideredWord, false);
}
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment