Skip to content
GitLab
Explore
Sign in
Primary navigation
Search or go to…
Project
LatinIME
Manage
Activity
Members
Labels
Plan
Issues
Issue boards
Milestones
Wiki
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Snippets
Deploy
Releases
Package Registry
Container Registry
Model registry
Operate
Terraform modules
Monitor
Incidents
Analyze
Value stream analytics
Contributor analytics
Repository analytics
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
keyboard
LatinIME
Commits
939e3f31
Commit
939e3f31
authored
12 years ago
by
Kurt Partridge
Committed by
Android (Google) Code Review
12 years ago
Browse files
Options
Downloads
Plain Diff
Merge "[Rlog59d] Pass separatorString through revertCommit"
parents
3e05370d
31156c81
No related branches found
Branches containing commit
No related tags found
Tags containing commit
No related merge requests found
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
java/src/com/android/inputmethod/latin/LatinIME.java
+1
-1
1 addition, 1 deletion
java/src/com/android/inputmethod/latin/LatinIME.java
java/src/com/android/inputmethod/research/ResearchLogger.java
+5
-3
5 additions, 3 deletions
.../src/com/android/inputmethod/research/ResearchLogger.java
with
6 additions
and
4 deletions
java/src/com/android/inputmethod/latin/LatinIME.java
+
1
−
1
View file @
939e3f31
...
...
@@ -2321,7 +2321,7 @@ public final class LatinIME extends InputMethodService implements KeyboardAction
}
if
(
ProductionFlag
.
IS_EXPERIMENTAL
)
{
ResearchLogger
.
latinIME_revertCommit
(
committedWord
,
originallyTypedWord
,
mWordComposer
.
isBatchMode
());
mWordComposer
.
isBatchMode
()
,
mLastComposedWord
.
mSeparatorString
);
ResearchLogger
.
getInstance
().
uncommitCurrentLogUnit
(
committedWord
,
true
/* dumpCurrentLogUnit */
);
}
...
...
This diff is collapsed.
Click to expand it.
java/src/com/android/inputmethod/research/ResearchLogger.java
+
5
−
3
View file @
939e3f31
...
...
@@ -1297,9 +1297,10 @@ public class ResearchLogger implements SharedPreferences.OnSharedPreferenceChang
*/
private
static
final
LogStatement
LOGSTATEMENT_LATINIME_REVERTCOMMIT
=
new
LogStatement
(
"LatinIMERevertCommit"
,
true
,
false
,
"committedWord"
,
"originallyTypedWord"
);
"originallyTypedWord"
,
"separatorString"
);
public
static
void
latinIME_revertCommit
(
final
String
committedWord
,
final
String
originallyTypedWord
,
final
boolean
isBatchMode
)
{
final
String
originallyTypedWord
,
final
boolean
isBatchMode
,
final
String
separatorString
)
{
final
ResearchLogger
researchLogger
=
getInstance
();
// TODO: Verify that mCurrentLogUnit has been restored and contains the reverted word.
final
LogUnit
logUnit
;
...
...
@@ -1314,7 +1315,8 @@ public class ResearchLogger implements SharedPreferences.OnSharedPreferenceChang
}
}
researchLogger
.
enqueueEvent
(
logUnit
!=
null
?
logUnit
:
researchLogger
.
mCurrentLogUnit
,
LOGSTATEMENT_LATINIME_REVERTCOMMIT
,
committedWord
,
originallyTypedWord
);
LOGSTATEMENT_LATINIME_REVERTCOMMIT
,
committedWord
,
originallyTypedWord
,
separatorString
);
researchLogger
.
mStatistics
.
recordRevertCommit
(
SystemClock
.
uptimeMillis
());
researchLogger
.
commitCurrentLogUnitAsWord
(
originallyTypedWord
,
Long
.
MAX_VALUE
,
isBatchMode
);
}
...
...
This diff is collapsed.
Click to expand it.
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment