Skip to content
Snippets Groups Projects
Commit 71c695da authored by Tadashi G. Takaoka's avatar Tadashi G. Takaoka
Browse files

Remove BIDI mirroring hack from Key

This change also removes isRtlKeyboard attribute from <Keyboard/>

Bug: 5948247
Change-Id: I85998f17ae146a4c8cd0f419ab820b746cb8974f
parent 40e90122
No related branches found
No related tags found
No related merge requests found
Showing
with 193 additions and 100 deletions
......@@ -102,8 +102,43 @@
<string name="more_keys_for_bullet"></string>
<!-- \u066d: ARABIC FIVE POINTED STAR -->
<string name="more_keys_for_star">★,\u066d</string>
<!-- \ufd3e: ORNATE LEFT PARENTHESIS -->
<string name="more_keys_for_left_parenthesis">[,{,&lt;,\ufd3e</string>
<!-- \ufd3f: ORNATE RIGHT PARENTHESIS -->
<string name="more_keys_for_right_parenthesis">],},&gt;,\ufd3f</string>
<!-- The all letters need to be mirrored are found at
http://www.unicode.org/Public/6.1.0/ucd/BidiMirroring.txt -->
<string name="output_text_for_left_parenthesis">)</string>
<string name="output_text_for_right_parenthesis">(</string>
<!-- \ufd3e: ORNATE LEFT PARENTHESIS
\ufd3f: ORNATE RIGHT PARENTHESIS -->
<string name="more_keys_for_left_parenthesis">[|],{|},&lt;|&gt;,\ufd3e|\ufd3f</string>
<string name="more_keys_for_right_parenthesis">]|[,}|{,&gt;|&lt;,\ufd3f|\ufd3e</string>
<string name="output_text_for_less_than">&gt;</string>
<string name="output_text_for_greater_than">&lt;</string>
<!-- \u2264: LESS-THAN OR EQUAL TO
\u2265: GREATER-THAN EQUAL TO
\u00ab: LEFT-POINTING DOUBLE ANGLE QUOTATION MARK
\u00bb: RIGHT-POINTING DOUBLE ANGLE QUOTATION MARK
\u2039: SINGLE LEFT-POINTING ANGLE QUOTATION MARK
\u203a: SINGLE RIGHT-POINTING ANGLE QUOTATION MARK
The following characters don't need BIDI mirroring.
\u2018: LEFT SINGLE QUOTATION MARK
\u2019: RIGHT SINGLE QUOTATION MARK
\u201a: SINGLE LOW-9 QUOTATION MARK
\u201b: SINGLE HIGH-REVERSED-9 QUOTATION MARK
\u201c: LEFT DOUBLE QUOTATION MARK
\u201d: RIGHT DOUBLE QUOTATION MARK
\u201e: DOUBLE LOW-9 QUOTATION MARK
\u201f: DOUBLE HIGH-REVERSED-9 QUOTATION MARK -->
<string name="more_keys_for_less_than">\u2264|\u2265,\u00ab|\u00bb,\u2039|\u203a</string>
<string name="more_keys_for_greater_than">\u2265|\u2264,\u00bb|\u00ab,\u203a|\u2039</string>
<string name="output_text_for_left_square_bracket">]</string>
<string name="output_text_for_right_square_bracket">[</string>
<string name="output_text_for_left_curly_bracket">}</string>
<string name="output_text_for_right_curly_bracket">{</string>
<!-- Note: Neither DroidSans nor Roboto have a glyph for DOUBLE HIGH-REVERSED-9 QUOTATION MARK. -->
<!-- <string name="more_keys_for_double_quote">\u201c,\u201d,\u201e,\u201f,\u00ab,\u00bb</string> -->
<!-- The 4-more keys will be displayed in order of "3,1,2,4". -->
<string name="more_keys_for_double_quote">\u201d,\u00ab|\u00bb,\u201c,\u00bb|\u00ab</string>
<!-- Note: Neither DroidSans nor Roboto have a glyph for DOUBLE HIGH-REVERSED-9 QUOTATION MARK. -->
<!-- <string name="more_keys_for_tablet_double_quote">\u201c,\u201d,\u201e,\u201f,\u00ab,\u00bb,\u2018,\u2019,\u201a,\u201b</string> -->
<!-- The 8-more keys with maxMoreKeysColumn=4 will be displayed in order of "3,1,2,4|7,5,6,8". -->
<string name="more_keys_for_tablet_double_quote">\u201d,\u00ab|\u00bb,\u201c,\u00bb|\u00ab,\u2019,\u201a,\u2018,\u201b</string>
</resources>
......@@ -19,7 +19,7 @@
-->
<resources xmlns:xliff="urn:oasis:names:tc:xliff:document:1.2">
<!-- The all letters need to be mirrored are found at
http://www.unicode.org/Public/6.0.0/ucd/extracted/DerivedBinaryProperties.txt -->
http://www.unicode.org/Public/6.1.0/ucd/BidiMirroring.txt -->
<!-- Symbols that are suggested between words -->
<string name="suggested_punctuations">!,?,\\,,:,;,\u0022,(|),)|(,\u0027,-,/,@,_</string>
</resources>
......@@ -20,4 +20,41 @@
<resources xmlns:xliff="urn:oasis:names:tc:xliff:document:1.2">
<string name="more_keys_for_star"></string>
<string name="more_keys_for_plus">±,﬩</string>
<!-- The all letters need to be mirrored are found at
http://www.unicode.org/Public/6.1.0/ucd/BidiMirroring.txt -->
<string name="output_text_for_left_parenthesis">)</string>
<string name="output_text_for_right_parenthesis">(</string>
<string name="more_keys_for_left_parenthesis">[|],{|},&lt;|&gt;</string>
<string name="more_keys_for_right_parenthesis">]|[,}|{,&gt;|&lt;</string>
<string name="output_text_for_less_than">&gt;</string>
<string name="output_text_for_greater_than">&lt;</string>
<!-- \u2264: LESS-THAN OR EQUAL TO
\u2265: GREATER-THAN EQUAL TO
\u00ab: LEFT-POINTING DOUBLE ANGLE QUOTATION MARK
\u00bb: RIGHT-POINTING DOUBLE ANGLE QUOTATION MARK
\u2039: SINGLE LEFT-POINTING ANGLE QUOTATION MARK
\u203a: SINGLE RIGHT-POINTING ANGLE QUOTATION MARK
The following characters don't need BIDI mirroring.
\u2018: LEFT SINGLE QUOTATION MARK
\u2019: RIGHT SINGLE QUOTATION MARK
\u201a: SINGLE LOW-9 QUOTATION MARK
\u201b: SINGLE HIGH-REVERSED-9 QUOTATION MARK
\u201c: LEFT DOUBLE QUOTATION MARK
\u201d: RIGHT DOUBLE QUOTATION MARK
\u201e: DOUBLE LOW-9 QUOTATION MARK
\u201f: DOUBLE HIGH-REVERSED-9 QUOTATION MARK -->
<string name="more_keys_for_less_than">\u2264|\u2265,\u00ab|\u00bb,\u2039|\u203a</string>
<string name="more_keys_for_greater_than">\u2265|\u2264,\u00bb|\u00ab,\u203a|\u2039</string>
<string name="output_text_for_left_square_bracket">]</string>
<string name="output_text_for_right_square_bracket">[</string>
<string name="output_text_for_left_curly_bracket">}</string>
<string name="output_text_for_right_curly_bracket">{</string>
<!-- Note: Neither DroidSans nor Roboto have a glyph for DOUBLE HIGH-REVERSED-9 QUOTATION MARK. -->
<!-- <string name="more_keys_for_double_quote">\u201c,\u201d,\u201e,\u201f,\u00ab,\u00bb</string> -->
<!-- The 4-more keys will be displayed in order of "3,1,2,4". -->
<string name="more_keys_for_double_quote">\u201d,\u00ab|\u00bb,\u201c,\u00bb|\u00ab</string>
<!-- Note: Neither DroidSans nor Roboto have a glyph for DOUBLE HIGH-REVERSED-9 QUOTATION MARK. -->
<!-- <string name="more_keys_for_tablet_double_quote">\u201c,\u201d,\u201e,\u201f,\u00ab,\u00bb,\u2018,\u2019,\u201a,\u201b</string> -->
<!-- The 8-more keys with maxMoreKeysColumn=4 will be displayed in order of "3,1,2,4|7,5,6,8". -->
<string name="more_keys_for_tablet_double_quote">\u201d,\u00ab|\u00bb,\u201c,\u00bb|\u00ab,\u2019,\u201a,\u2018,\u201b</string>
</resources>
......@@ -19,7 +19,7 @@
-->
<resources xmlns:xliff="urn:oasis:names:tc:xliff:document:1.2">
<!-- The all letters need to be mirrored are found at
http://www.unicode.org/Public/6.0.0/ucd/extracted/DerivedBinaryProperties.txt -->
http://www.unicode.org/Public/6.1.0/ucd/BidiMirroring.txt -->
<!-- Symbols that are suggested between words -->
<string name="suggested_punctuations">!,?,\\,,:,;,\u0022,(|),)|(,\u0027,-,/,@,_</string>
</resources>
......@@ -202,8 +202,6 @@
<attr name="verticalGap" format="dimension|fraction" />
<!-- More keys keyboard layout template -->
<attr name="moreKeysTemplate" format="reference" />
<!-- True if the keyboard is Right-To-Left -->
<attr name="isRtlKeyboard" format="boolean" />
<!-- Icon set for key top and key preview. -->
<attr name="iconShiftKey" format="reference" />
<attr name="iconDeleteKey" format="reference" />
......
......@@ -112,6 +112,43 @@
<string name="more_keys_for_bullet">♪,♥,♠,♦,♣</string>
<string name="more_keys_for_star">†,‡,★</string>
<string name="more_keys_for_plus">±</string>
<!-- The all letters need to be mirrored are found at
http://www.unicode.org/Public/6.1.0/ucd/BidiMirroring.txt -->
<string name="output_text_for_left_parenthesis">(</string>
<string name="output_text_for_right_parenthesis">)</string>
<string name="more_keys_for_left_parenthesis">[,{,&lt;</string>
<string name="more_keys_for_right_parenthesis">],},&gt;</string>
<string name="output_text_for_less_than">&lt;</string>
<string name="output_text_for_greater_than">&gt;</string>
<!-- \u2264: LESS-THAN OR EQUAL TO
\u2265: GREATER-THAN EQUAL TO
\u00ab: LEFT-POINTING DOUBLE ANGLE QUOTATION MARK
\u00bb: RIGHT-POINTING DOUBLE ANGLE QUOTATION MARK
\u2039: SINGLE LEFT-POINTING ANGLE QUOTATION MARK
\u203a: SINGLE RIGHT-POINTING ANGLE QUOTATION MARK
The following characters don't need BIDI mirroring.
\u2018: LEFT SINGLE QUOTATION MARK
\u2019: RIGHT SINGLE QUOTATION MARK
\u201a: SINGLE LOW-9 QUOTATION MARK
\u201b: SINGLE HIGH-REVERSED-9 QUOTATION MARK
\u201c: LEFT DOUBLE QUOTATION MARK
\u201d: RIGHT DOUBLE QUOTATION MARK
\u201e: DOUBLE LOW-9 QUOTATION MARK
\u201f: DOUBLE HIGH-REVERSED-9 QUOTATION MARK -->
<string name="more_keys_for_less_than">\u2264,\u00ab,\u2039</string>
<string name="more_keys_for_greater_than">\u2265,\u00bb,\u203a</string>
<string name="output_text_for_left_square_bracket">[</string>
<string name="output_text_for_right_square_bracket">]</string>
<string name="output_text_for_left_curly_bracket">{</string>
<string name="output_text_for_right_curly_bracket">}</string>
<!-- The 4-more keys will be displayed in order of "3,1,2,4". -->
<string name="more_keys_for_single_quote">\u2019,\u201a,\u2018,\u201b</string>
<!-- Note: Neither DroidSans nor Roboto have a glyph for DOUBLE HIGH-REVERSED-9 QUOTATION MARK. -->
<!-- <string name="more_keys_for_double_quote">\u201c,\u201d,\u201e,\u201f,\u00ab,\u00bb</string> -->
<!-- The 4-more keys will be displayed in order of "3,1,2,4". -->
<string name="more_keys_for_double_quote">\u201d,\u00ab,\u201c,\u00bb</string>
<!-- Note: Neither DroidSans nor Roboto have a glyph for DOUBLE HIGH-REVERSED-9 QUOTATION MARK. -->
<!-- <string name="more_keys_for_tablet_double_quote">\u201c,\u201d,\u201e,\u201f,\u00ab,\u00bb,\u2018,\u2019,\u201a,\u201b</string> -->
<!-- The 8-more keys with maxMoreKeysColumn=4 will be displayed in order of "3,1,2,4|7,5,6,8". -->
<string name="more_keys_for_tablet_double_quote">\u201d,\u00ab,\u201c,\u00bb,\u2019,\u201a,\u2018,\u201b</string>
</resources>
......@@ -116,7 +116,10 @@
latin:keyLabel="n"
latin:moreKeys="@string/more_keys_for_n" />
<Key
latin:keyLabel="\'" />
latin:keyLabel="\'"
latin:keyHintLabel=":"
latin:moreKeys=":"
latin:keyStyle="hasShiftedLetterHintStyle" />
<include
latin:keyboardLayout="@xml/keys_comma_period" />
<include
......
......@@ -95,12 +95,8 @@
<Key
latin:keyLabel="+"
latin:moreKeys="@string/more_keys_for_plus" />
<Key
latin:keyLabel="("
latin:moreKeys="[,{,&lt;" />
<Key
latin:keyLabel=")"
latin:moreKeys="],},&gt;" />
<include
latin:keyboardLayout="@xml/keys_parentheses" />
<Key
latin:keyStyle="returnKeyStyle"
latin:keyXPos="-14.6%p"
......@@ -112,12 +108,8 @@
<Key
latin:keyStyle="toMoreSymbolKeyStyle"
latin:keyWidth="10.0%p" />
<Key
latin:keyLabel="&lt;"
latin:moreKeys="≤,«,‹" />
<Key
latin:keyLabel="&gt;"
latin:moreKeys="≥,»,›" />
<include
latin:keyboardLayout="@xml/keys_less_greater" />
<Key
latin:keyLabel="="
latin:moreKeys="≠,≈" />
......@@ -126,8 +118,7 @@
latin:mode="url"
>
<Key
latin:keyLabel="\'"
latin:moreKeys="‘,’,‚,‛" />
latin:keyLabel="\'" />
</case>
<default>
<Key
......@@ -166,11 +157,10 @@
latin:keyStyle="spaceKeyStyle"
latin:keyXPos="30.750%p"
latin:keyWidth="39.750%p" />
<!-- Note: DroidSans doesn't have double-high-reversed-quotation '\u201f' glyph. -->
<!-- latin:moreKeys="“,”,„,‟,«,»,‘,’,‚,‛" -->
<Key
latin:keyLabel="&quot;"
latin:moreKeys="“,”,«,»,‘,’,‚,‛" />
latin:moreKeys="@string/more_keys_for_tablet_double_quote"
latin:maxMoreKeysColumn="4" />
<Key
latin:keyLabel="_" />
<Spacer
......
......@@ -77,10 +77,8 @@
<Key
latin:keyLabel="±"
latin:moreKeys="∞" />
<Key
latin:keyLabel="{" />
<Key
latin:keyLabel="}" />
<include
latin:keyboardLayout="@xml/keys_curly_brackets" />
<Key
latin:keyStyle="returnKeyStyle"
latin:keyXPos="-14.6%p"
......@@ -102,10 +100,8 @@
latin:keyLabel="™" />
<Key
latin:keyLabel="℅" />
<Key
latin:keyLabel="[" />
<Key
latin:keyLabel="]" />
<include
latin:keyboardLayout="@xml/keys_square_brackets" />
<Key
latin:keyLabel="¡" />
<Key
......
......@@ -124,9 +124,9 @@
latin:moreKeys="@string/more_keys_for_n" />
<Key
latin:keyLabel="\'"
latin:keyLabelFlags="hasShiftedLetterHint"
latin:keyHintLabel=":"
latin:moreKeys=":" />
latin:moreKeys=":"
latin:keyStyle="hasShiftedLetterHintStyle" />
<include
latin:keyboardLayout="@xml/keys_comma_period" />
<Key
......
......@@ -102,12 +102,8 @@
<Key
latin:keyLabel="+"
latin:moreKeys="@string/more_keys_for_plus" />
<Key
latin:keyLabel="("
latin:moreKeys="[,{,&lt;" />
<Key
latin:keyLabel=")"
latin:moreKeys="],},&gt;" />
<include
latin:keyboardLayout="@xml/keys_parentheses" />
<Key
latin:keyStyle="returnKeyStyle"
latin:keyXPos="-15.704%p"
......@@ -119,12 +115,8 @@
<Key
latin:keyStyle="toMoreSymbolKeyStyle"
latin:keyWidth="13.829%p" />
<Key
latin:keyLabel="&lt;"
latin:moreKeys="≤,«,‹" />
<Key
latin:keyLabel="&gt;"
latin:moreKeys="≥,»,›" />
<include
latin:keyboardLayout="@xml/keys_less_greater" />
<Key
latin:keyLabel="="
latin:moreKeys="≠,≈" />
......@@ -133,8 +125,7 @@
latin:mode="url"
>
<Key
latin:keyLabel="\'"
latin:moreKeys="‘,’,‚,‛" />
latin:keyLabel="\'" />
</case>
<default>
<Key
......@@ -181,11 +172,10 @@
latin:keyStyle="spaceKeyStyle"
latin:keyXPos="31.250%p"
latin:keyWidth="37.500%p" />
<!-- Note: DroidSans doesn't have double-high-reversed-quotation '\u201f' glyph. -->
<!-- latin:moreKeys="“,”,„,‟,«,»,‘,’,‚,‛" -->
<Key
latin:keyLabel="&quot;"
latin:moreKeys="“,”,«,»,‘,’,‚,‛" />
latin:moreKeys="@string/more_keys_for_tablet_double_quote"
latin:maxMoreKeysColumn="4" />
<Key
latin:keyLabel="_" />
<switch>
......
......@@ -84,10 +84,8 @@
<Key
latin:keyLabel="±"
latin:moreKeys="∞" />
<Key
latin:keyLabel="{" />
<Key
latin:keyLabel="}" />
<include
latin:keyboardLayout="@xml/keys_curly_brackets" />
<Key
latin:keyStyle="returnKeyStyle"
latin:keyXPos="-15.704%p"
......@@ -109,10 +107,8 @@
latin:keyLabel="™" />
<Key
latin:keyLabel="℅" />
<Key
latin:keyLabel="[" />
<Key
latin:keyLabel="]" />
<include
latin:keyboardLayout="@xml/keys_square_brackets" />
<Key
latin:keyLabel="¡" />
<Key
......
......@@ -20,7 +20,6 @@
<Keyboard
xmlns:latin="http://schemas.android.com/apk/res/com.android.inputmethod.latin"
latin:isRtlKeyboard="true"
>
<include
latin:keyboardLayout="@xml/rows_arabic" />
......
......@@ -20,7 +20,6 @@
<Keyboard
xmlns:latin="http://schemas.android.com/apk/res/com.android.inputmethod.latin"
latin:isRtlKeyboard="true"
>
<include
latin:keyboardLayout="@xml/rows_hebrew" />
......
......@@ -2,7 +2,7 @@
<!--
/*
**
** Copyright 2011, The Android Open Source Project
** Copyright 2012, The Android Open Source Project
**
** Licensed under the Apache License, Version 2.0 (the "License");
** you may not use this file except in compliance with the License.
......@@ -18,10 +18,13 @@
*/
-->
<Keyboard
<merge
xmlns:latin="http://schemas.android.com/apk/res/com.android.inputmethod.latin"
latin:isRtlKeyboard="true"
>
<include
latin:keyboardLayout="@xml/rows_symbols" />
</Keyboard>
<Key
latin:keyLabel="{"
latin:keyOutputText="@string/output_text_for_left_curly_bracket" />
<Key
latin:keyLabel="}"
latin:keyOutputText="@string/output_text_for_right_curly_bracket" />
</merge>
......@@ -2,7 +2,7 @@
<!--
/*
**
** Copyright 2011, The Android Open Source Project
** Copyright 2012, The Android Open Source Project
**
** Licensed under the Apache License, Version 2.0 (the "License");
** you may not use this file except in compliance with the License.
......@@ -18,10 +18,15 @@
*/
-->
<Keyboard
<merge
xmlns:latin="http://schemas.android.com/apk/res/com.android.inputmethod.latin"
latin:isRtlKeyboard="true"
>
<include
latin:keyboardLayout="@xml/rows_symbols" />
</Keyboard>
<Key
latin:keyLabel="&lt;"
latin:keyOutputText="@string/output_text_for_less_than"
latin:moreKeys="@string/more_keys_for_less_than" />
<Key
latin:keyLabel="&gt;"
latin:keyOutputText="@string/output_text_for_greater_than"
latin:moreKeys="@string/more_keys_for_greater_than" />
</merge>
......@@ -2,7 +2,7 @@
<!--
/*
**
** Copyright 2011, The Android Open Source Project
** Copyright 2012, The Android Open Source Project
**
** Licensed under the Apache License, Version 2.0 (the "License");
** you may not use this file except in compliance with the License.
......@@ -18,10 +18,15 @@
*/
-->
<Keyboard
<merge
xmlns:latin="http://schemas.android.com/apk/res/com.android.inputmethod.latin"
latin:isRtlKeyboard="true"
>
<include
latin:keyboardLayout="@xml/rows_symbols_shift" />
</Keyboard>
<Key
latin:keyLabel="("
latin:keyOutputText="@string/output_text_for_left_parenthesis"
latin:moreKeys="@string/more_keys_for_left_parenthesis" />
<Key
latin:keyLabel=")"
latin:keyOutputText="@string/output_text_for_right_parenthesis"
latin:moreKeys="@string/more_keys_for_right_parenthesis" />
</merge>
......@@ -2,7 +2,7 @@
<!--
/*
**
** Copyright 2011, The Android Open Source Project
** Copyright 2012, The Android Open Source Project
**
** Licensed under the Apache License, Version 2.0 (the "License");
** you may not use this file except in compliance with the License.
......@@ -18,10 +18,13 @@
*/
-->
<Keyboard
<merge
xmlns:latin="http://schemas.android.com/apk/res/com.android.inputmethod.latin"
latin:isRtlKeyboard="true"
>
<include
latin:keyboardLayout="@xml/rows_symbols_shift" />
</Keyboard>
<Key
latin:keyLabel="["
latin:keyOutputText="@string/output_text_for_left_square_bracket" />
<Key
latin:keyLabel="]"
latin:keyOutputText="@string/output_text_for_right_square_bracket" />
</merge>
......@@ -130,9 +130,13 @@
<Key
latin:keyLabel="n"
latin:moreKeys="@string/more_keys_for_n" />
<!-- TODO: Introduce a flag, such as strinctMoreKeysOrder, to control moreKeys display
order more precisely. -->
<!-- This key is close enough to right edge, so that the 4-more keys will be displayed in
order of "4,3,1,2". See @string/more_keys_for_single_quote -->
<Key
latin:keyLabel="\'"
latin:moreKeys="‘,’,‚,‛" />
latin:moreKeys="\u2018,\u2019,\u201b,\u201a" />
<Key
latin:keyStyle="deleteKeyStyle"
latin:keyWidth="fillRight"
......
......@@ -93,13 +93,8 @@
<Key
latin:keyLabel="+"
latin:moreKeys="@string/more_keys_for_plus" />
<Key
latin:keyLabel="("
latin:moreKeys="@string/more_keys_for_left_parenthesis" />
<Key
latin:keyLabel=")"
latin:moreKeys="@string/more_keys_for_right_parenthesis"
latin:keyWidth="fillRight" />
<include
latin:keyboardLayout="@xml/keys_parentheses" />
</Row>
<Row
latin:keyWidth="10%p"
......@@ -111,15 +106,13 @@
<Key
latin:keyLabel="!"
latin:moreKeys="¡" />
<!-- Note: Neither DroidSans nor Roboto have a glyph for ‟ Double high-reversed-9 quotation mark U+201F. -->
<!-- latin:moreKeys="“,”,„,‟,«,»" -->
<Key
latin:keyLabel="&quot;"
latin:moreKeys="“,”,«,»"
latin:maxMoreKeysColumn="6" />
latin:moreKeys="@string/more_keys_for_double_quote"
latin:maxMoreKeysColumn="4" />
<Key
latin:keyLabel="\'"
latin:moreKeys="‘,’,‚,‛" />
latin:moreKeys="@string/more_keys_for_single_quote" />
<Key
latin:keyLabel=":" />
<Key
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment