Skip to content
Snippets Groups Projects
Commit 1a42236a authored by Tadashi G. Takaoka's avatar Tadashi G. Takaoka Committed by Android Git Automerger
Browse files

am 4b6756db: Merge "Remove unnecessary harmful finish() from SettingsActivity"

* commit '4b6756db':
  Remove unnecessary harmful finish() from SettingsActivity
parents 5f6492c5 4b6756db
No related branches found
No related tags found
No related merge requests found
...@@ -16,7 +16,6 @@ ...@@ -16,7 +16,6 @@
package com.android.inputmethod.latin; package com.android.inputmethod.latin;
import android.app.Activity;
import android.app.backup.BackupManager; import android.app.backup.BackupManager;
import android.content.Context; import android.content.Context;
import android.content.Intent; import android.content.Intent;
...@@ -115,12 +114,8 @@ public final class SettingsFragment extends InputMethodSettingsFragment ...@@ -115,12 +114,8 @@ public final class SettingsFragment extends InputMethodSettingsFragment
if (FeedbackUtils.isFeedbackFormSupported()) { if (FeedbackUtils.isFeedbackFormSupported()) {
feedbackSettings.setOnPreferenceClickListener(new OnPreferenceClickListener() { feedbackSettings.setOnPreferenceClickListener(new OnPreferenceClickListener() {
@Override @Override
public boolean onPreferenceClick(Preference arg0) { public boolean onPreferenceClick(final Preference pref) {
final Activity activity = getActivity(); FeedbackUtils.showFeedbackForm(getActivity());
FeedbackUtils.showFeedbackForm(activity);
if (!activity.isFinishing()) {
activity.finish();
}
return true; return true;
} }
}); });
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment