Skip to content
GitLab
Explore
Sign in
Primary navigation
Search or go to…
Project
LatinIME
Manage
Activity
Members
Labels
Plan
Issues
Issue boards
Milestones
Wiki
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Snippets
Deploy
Releases
Package Registry
Container Registry
Model registry
Operate
Terraform modules
Monitor
Incidents
Analyze
Value stream analytics
Contributor analytics
Repository analytics
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
keyboard
LatinIME
Commits
14b800d8
Commit
14b800d8
authored
12 years ago
by
Kurt Partridge
Browse files
Options
Downloads
Patches
Plain Diff
[Rlog14] Increase feedback buffer to cover whole session
Change-Id: I55b61d9ca6eecd56181b8d2913f71559555cd89e
parent
34b88560
No related branches found
No related tags found
No related merge requests found
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
java/res/values/strings.xml
+1
-2
1 addition, 2 deletions
java/res/values/strings.xml
java/src/com/android/inputmethod/research/ResearchLogger.java
+3
-4
3 additions, 4 deletions
.../src/com/android/inputmethod/research/ResearchLogger.java
with
4 additions
and
6 deletions
java/res/values/strings.xml
+
1
−
2
View file @
14b800d8
...
@@ -269,8 +269,7 @@
...
@@ -269,8 +269,7 @@
<string
name=
"research_feedback_dialog_title"
translatable=
"false"
>
Send feedback
</string>
<string
name=
"research_feedback_dialog_title"
translatable=
"false"
>
Send feedback
</string>
<!-- Text for checkbox option to include user data in feedback for research purposes [CHAR LIMIT=50] -->
<!-- Text for checkbox option to include user data in feedback for research purposes [CHAR LIMIT=50] -->
<!-- TODO: remove translatable=false attribute once text is stable -->
<!-- TODO: remove translatable=false attribute once text is stable -->
<!-- TODO: handle multilingual plurals -->
<string
name=
"research_feedback_include_history_label"
translatable=
"false"
>
Include session history
</string>
<string
name=
"research_feedback_include_history_label"
translatable=
"false"
>
Include last
<xliff:g
id=
"word"
>
%d
</xliff:g>
words entered
</string>
<!-- Hint to user about the text entry field where they should enter research feedback [CHAR LIMIT=40] -->
<!-- Hint to user about the text entry field where they should enter research feedback [CHAR LIMIT=40] -->
<!-- TODO: remove translatable=false attribute once text is stable -->
<!-- TODO: remove translatable=false attribute once text is stable -->
<string
name=
"research_feedback_hint"
translatable=
"false"
>
Enter your feedback here.
</string>
<string
name=
"research_feedback_hint"
translatable=
"false"
>
Enter your feedback here.
</string>
...
...
This diff is collapsed.
Click to expand it.
java/src/com/android/inputmethod/research/ResearchLogger.java
+
3
−
4
View file @
14b800d8
...
@@ -106,7 +106,8 @@ public class ResearchLogger implements SharedPreferences.OnSharedPreferenceChang
...
@@ -106,7 +106,8 @@ public class ResearchLogger implements SharedPreferences.OnSharedPreferenceChang
// Change the default indicator to something very visible. Currently two red vertical bars on
// Change the default indicator to something very visible. Currently two red vertical bars on
// either side of they keyboard.
// either side of they keyboard.
private
static
final
boolean
IS_SHOWING_INDICATOR_CLEARLY
=
false
||
IS_LOGGING_EVERYTHING
;
private
static
final
boolean
IS_SHOWING_INDICATOR_CLEARLY
=
false
||
IS_LOGGING_EVERYTHING
;
public
static
final
int
FEEDBACK_WORD_BUFFER_SIZE
=
5
;
// FEEDBACK_WORD_BUFFER_SIZE should add 1 because it must also hold the feedback LogUnit itself.
public
static
final
int
FEEDBACK_WORD_BUFFER_SIZE
=
(
Integer
.
MAX_VALUE
-
1
)
+
1
;
// constants related to specific log points
// constants related to specific log points
private
static
final
String
WHITESPACE_SEPARATORS
=
" \t\n\r"
;
private
static
final
String
WHITESPACE_SEPARATORS
=
" \t\n\r"
;
...
@@ -391,9 +392,7 @@ public class ResearchLogger implements SharedPreferences.OnSharedPreferenceChang
...
@@ -391,9 +392,7 @@ public class ResearchLogger implements SharedPreferences.OnSharedPreferenceChang
}
}
if
(
mFeedbackLogBuffer
==
null
)
{
if
(
mFeedbackLogBuffer
==
null
)
{
mFeedbackLog
=
new
ResearchLog
(
createLogFile
(
mFilesDir
),
mLatinIME
);
mFeedbackLog
=
new
ResearchLog
(
createLogFile
(
mFilesDir
),
mLatinIME
);
// LogBuffer is one more than FEEDBACK_WORD_BUFFER_SIZE, because it must also hold
mFeedbackLogBuffer
=
new
FixedLogBuffer
(
FEEDBACK_WORD_BUFFER_SIZE
);
// the feedback LogUnit itself.
mFeedbackLogBuffer
=
new
FixedLogBuffer
(
FEEDBACK_WORD_BUFFER_SIZE
+
1
);
}
}
}
}
...
...
This diff is collapsed.
Click to expand it.
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment