Skip to content
Snippets Groups Projects
  • Jean Chalard's avatar
    f735117d
    Fix a pernicious bug with caps. · f735117d
    Jean Chalard authored
    What's happening here is, setAlphabetKeyboard sets the
    keyboard to AUTOMATIC_SHIFTED and updates the keyboard, then
    restoring the keyboard old state sets it back to UNSHIFTED without
    updating it. When we finally know what the correct value is,
    we try to set it to UNSHIFTED, but since that's already the currently
    recorded state, it skips updating the keyboard forever.
    
    The solution is to avoid setting the shift state without updating the
    keyboard.
    
    Bug: 10948582
    Change-Id: Ic8670401e378f8284e851281f91a9ad93eac8e90
    f735117d
    History
    Fix a pernicious bug with caps.
    Jean Chalard authored
    What's happening here is, setAlphabetKeyboard sets the
    keyboard to AUTOMATIC_SHIFTED and updates the keyboard, then
    restoring the keyboard old state sets it back to UNSHIFTED without
    updating it. When we finally know what the correct value is,
    we try to set it to UNSHIFTED, but since that's already the currently
    recorded state, it skips updating the keyboard forever.
    
    The solution is to avoid setting the shift state without updating the
    keyboard.
    
    Bug: 10948582
    Change-Id: Ic8670401e378f8284e851281f91a9ad93eac8e90