diff --git a/java/res/values/attrs.xml b/java/res/values/attrs.xml index 78cf34de729f9cfb79790cee0a84b2a7214015a1..055060642002f0803d90a9c66c58916453ee8941 100644 --- a/java/res/values/attrs.xml +++ b/java/res/values/attrs.xml @@ -111,6 +111,7 @@ <attr name="keyPreviewOffset" format="dimension" /> <!-- Height of the key press feedback popup. --> <attr name="keyPreviewHeight" format="dimension" /> + <!-- TODO: consolidate key preview linger timeout with the key preview animation parameters. --> <!-- Delay after key releasing and key press feedback dismissing in millisecond --> <attr name="keyPreviewLingerTimeout" format="integer" /> <!-- Layout resource for more keys keyboard --> diff --git a/java/res/values/config-common.xml b/java/res/values/config-common.xml index 1b44bad50b40091f6bf32d9e9de63d3875e476c4..224aabdbb9a50de07582fe58a3cd9bb6bc4c6ba6 100644 --- a/java/res/values/config-common.xml +++ b/java/res/values/config-common.xml @@ -35,10 +35,11 @@ <integer name="config_ignore_alt_code_key_timeout">350</integer> - <integer name="config_key_preview_show_up_duration">35</integer> - <integer name="config_key_preview_dismiss_duration">40</integer> - <fraction name="config_key_preview_show_up_start_scale">70%</fraction> - <fraction name="config_key_preview_dismiss_end_scale">70%</fraction> + <integer name="config_key_preview_show_up_duration">0</integer> + <integer name="config_key_preview_dismiss_duration">70</integer> + <fraction name="config_key_preview_show_up_start_scale">100%</fraction> + <fraction name="config_key_preview_dismiss_end_scale">100%</fraction> + <!-- TODO: consolidate key preview linger timeout with the above animation parameters. --> <integer name="config_key_preview_linger_timeout">70</integer> <!-- Suppress showing key preview duration after batch input in millisecond --> <integer name="config_suppress_key_preview_after_batch_input_duration">1000</integer> diff --git a/java/res/values/themes-common.xml b/java/res/values/themes-common.xml index fc96d19a11ec00dbff2ae76eb8008a3a5cb37038..eb6cdd9750a8556ff60b9d2ddc7117bbe95cbe88 100644 --- a/java/res/values/themes-common.xml +++ b/java/res/values/themes-common.xml @@ -77,6 +77,7 @@ <item name="ignoreAltCodeKeyTimeout">@integer/config_ignore_alt_code_key_timeout</item> <item name="keyPreviewLayout">@layout/key_preview</item> <item name="keyPreviewHeight">@dimen/config_key_preview_height</item> + <!-- TODO: consolidate key preview linger timeout with the key preview animation parameters. --> <item name="keyPreviewLingerTimeout">@integer/config_key_preview_linger_timeout</item> <item name="moreKeysKeyboardLayout">@layout/more_keys_keyboard</item> <item name="showMoreKeysKeyboardAtTouchedPoint">@bool/config_show_more_keys_keyboard_at_touched_point</item> diff --git a/java/res/xml/prefs.xml b/java/res/xml/prefs.xml index 49f07188a0f11ccb946c3f6c6ac41a47d0166dd7..a39ce4ae850a6683d1c1de6bc69d6dab790cd6d0 100644 --- a/java/res/xml/prefs.xml +++ b/java/res/xml/prefs.xml @@ -175,6 +175,7 @@ android:fragment="com.android.inputmethod.latin.settings.AdditionalSubtypeSettings" android:key="custom_input_styles" android:title="@string/custom_input_styles_title" /> + <!-- TODO: consolidate key preview dismiss delay with the key preview animation parameters. --> <ListPreference android:key="pref_key_preview_popup_dismiss_delay" android:title="@string/key_preview_popup_dismiss_delay" /> diff --git a/java/src/com/android/inputmethod/latin/settings/Settings.java b/java/src/com/android/inputmethod/latin/settings/Settings.java index 45c5b733f7509345c4c24c09755367a115eec8f9..b51c765f02241364ef30b5da37a23cc444bd344c 100644 --- a/java/src/com/android/inputmethod/latin/settings/Settings.java +++ b/java/src/com/android/inputmethod/latin/settings/Settings.java @@ -66,6 +66,7 @@ public final class Settings implements SharedPreferences.OnSharedPreferenceChang "pref_include_other_imes_in_language_switch_list"; public static final String PREF_KEYBOARD_LAYOUT = "pref_keyboard_layout_20110916"; public static final String PREF_CUSTOM_INPUT_STYLES = "custom_input_styles"; + // TODO: consolidate key preview dismiss delay with the key preview animation parameters. public static final String PREF_KEY_PREVIEW_POPUP_DISMISS_DELAY = "pref_key_preview_popup_dismiss_delay"; public static final String PREF_BIGRAM_PREDICTIONS = "next_word_prediction"; diff --git a/java/src/com/android/inputmethod/latin/settings/SettingsFragment.java b/java/src/com/android/inputmethod/latin/settings/SettingsFragment.java index 67017a43ba983894bea7d0ec216870512fb34953..bb5547fc9b7bf04571e75a6c72c09da3f8120a9a 100644 --- a/java/src/com/android/inputmethod/latin/settings/SettingsFragment.java +++ b/java/src/com/android/inputmethod/latin/settings/SettingsFragment.java @@ -169,6 +169,7 @@ public final class SettingsFragment extends InputMethodSettingsFragment removePreference(Settings.PREF_VIBRATION_DURATION_SETTINGS, advancedSettings); } + // TODO: consolidate key preview dismiss delay with the key preview animation parameters. if (!Settings.readFromBuildConfigIfToShowKeyPreviewPopupOption(res)) { removePreference(Settings.PREF_POPUP_ON, generalSettings); removePreference(Settings.PREF_KEY_PREVIEW_POPUP_DISMISS_DELAY, advancedSettings);