From 9579936bcf6bc5cecee315c5e40a30af77f47dfd Mon Sep 17 00:00:00 2001
From: Kurt Partridge <kep@google.com>
Date: Fri, 11 Jan 2013 10:18:53 -0800
Subject: [PATCH] [Rlog67] Renaming clarification
ResearchLogger.latinIME_handleSeparator wasn't doing anything really specific to
the separator, so its implementation has been renamed according to its role.
Change-Id: I24e8691c7dc440dd067e96d23e50463683e17cfc
---
.../com/android/inputmethod/latin/LatinIME.java | 2 +-
.../inputmethod/research/ResearchLogger.java | 16 ++++++++++------
2 files changed, 11 insertions(+), 7 deletions(-)
diff --git a/java/src/com/android/inputmethod/latin/LatinIME.java b/java/src/com/android/inputmethod/latin/LatinIME.java
index ab21cff476..8913b1543c 100644
--- a/java/src/com/android/inputmethod/latin/LatinIME.java
+++ b/java/src/com/android/inputmethod/latin/LatinIME.java
@@ -1870,7 +1870,7 @@ public final class LatinIME extends InputMethodService implements KeyboardAction
private boolean handleSeparator(final int primaryCode, final int x, final int y,
final int spaceState) {
if (ProductionFlag.IS_EXPERIMENTAL) {
- ResearchLogger.latinIME_handleSeparator();
+ ResearchLogger.recordTimeForLogUnitSplit();
}
boolean didAutoCorrect = false;
// Handle separator
diff --git a/java/src/com/android/inputmethod/research/ResearchLogger.java b/java/src/com/android/inputmethod/research/ResearchLogger.java
index 8b6bff4953..f4249a0451 100644
--- a/java/src/com/android/inputmethod/research/ResearchLogger.java
+++ b/java/src/com/android/inputmethod/research/ResearchLogger.java
@@ -1705,12 +1705,16 @@ public class ResearchLogger implements SharedPreferences.OnSharedPreferenceChang
researchLogger.enqueueEvent(LOGSTATEMENT_ONUSERPAUSE, interval);
}
- public static void latinIME_handleSeparator() {
- // Reset the saved down event time. For tapping, motion events, etc. before the separator
- // are assigned to the previous LogUnit, and events after the separator are assigned to the
- // next LogUnit. In the case of multitap, this might capture down events corresponding to
- // the next word, however it should not be more than a character or two.
- getInstance().setSavedDownEventTime(SystemClock.uptimeMillis());
+ /**
+ * Record the current time in case the LogUnit is later split.
+ *
+ * If the current logUnitis split, then tapping, motion events, etc. before this time should
+ * be assigned to one LogUnit, and events after this time should go into the following LogUnit.
+ */
+ public static void recordTimeForLogUnitSplit() {
+ final ResearchLogger researchLogger = getInstance();
+ researchLogger.setSavedDownEventTime(SystemClock.uptimeMillis());
+ researchLogger.mSavedDownEventTime = Long.MAX_VALUE;
}
/**
--
GitLab