diff --git a/java/src/com/android/inputmethod/keyboard/KeyboardView.java b/java/src/com/android/inputmethod/keyboard/KeyboardView.java index 6af4123c90dbb19ea9ae1a2d7bda4c77184d8102..e69dc581b09b6336bd0c174d8c3aa1ec74437080 100644 --- a/java/src/com/android/inputmethod/keyboard/KeyboardView.java +++ b/java/src/com/android/inputmethod/keyboard/KeyboardView.java @@ -974,5 +974,9 @@ public class KeyboardView extends View implements PointerTracker.DrawingProxy { if (mPreviewPlacer != null) { mPreviewPlacer.removeAllViews(); } + if (mBuffer != null) { + mBuffer.recycle(); + mBuffer = null; + } } } diff --git a/java/src/com/android/inputmethod/keyboard/LatinKeyboard.java b/java/src/com/android/inputmethod/keyboard/LatinKeyboard.java index 3452720445f74c4188f8eff5a2a5bbb88c8c9818..c51f1849bbd7c441a4e2a01719f25a4a03633d89 100644 --- a/java/src/com/android/inputmethod/keyboard/LatinKeyboard.java +++ b/java/src/com/android/inputmethod/keyboard/LatinKeyboard.java @@ -59,8 +59,8 @@ public class LatinKeyboard extends Keyboard { private final int mSpacebarTextColor; private final int mSpacebarTextShadowColor; private float mSpacebarTextFadeFactor = 0.0f; - private final HashMap<Integer, SoftReference<BitmapDrawable>> mSpaceDrawableCache = - new HashMap<Integer, SoftReference<BitmapDrawable>>(); + private final HashMap<Integer, BitmapDrawable> mSpaceDrawableCache = + new HashMap<Integer, BitmapDrawable>(); private final boolean mIsSpacebarTriggeringPopupByLongPress; /* Shortcut key and its icons if available */ @@ -249,13 +249,13 @@ public class LatinKeyboard extends Keyboard { private BitmapDrawable getSpaceDrawable(Locale locale, boolean isAutoCorrection) { final Integer hashCode = Arrays.hashCode( new Object[] { locale, isAutoCorrection, mSpacebarTextFadeFactor }); - final SoftReference<BitmapDrawable> ref = mSpaceDrawableCache.get(hashCode); - BitmapDrawable drawable = (ref == null) ? null : ref.get(); - if (drawable == null) { - drawable = new BitmapDrawable(mRes, drawSpacebar( - locale, isAutoCorrection, mSpacebarTextFadeFactor)); - mSpaceDrawableCache.put(hashCode, new SoftReference<BitmapDrawable>(drawable)); + final BitmapDrawable cached = mSpaceDrawableCache.get(hashCode); + if (cached != null) { + return cached; } + final BitmapDrawable drawable = new BitmapDrawable(mRes, drawSpacebar( + locale, isAutoCorrection, mSpacebarTextFadeFactor)); + mSpaceDrawableCache.put(hashCode, drawable); return drawable; }