From 46941882b2c3f7467ce3d77be6948cfa7aafe548 Mon Sep 17 00:00:00 2001 From: "Tadashi G. Takaoka" <takaoka@google.com> Date: Wed, 29 Sep 2010 12:19:51 +0900 Subject: [PATCH] Tune mini keyboard vertical correction to match with key height Bug: 3040529 Change-Id: I8e3cc635737224537a019e66c38e1e2ea7a8bb8b --- java/res/layout/keyboard_popup.xml | 2 +- java/res/values-land/dimens.xml | 4 +++- java/res/values/dimens.xml | 4 +++- 3 files changed, 7 insertions(+), 3 deletions(-) diff --git a/java/res/layout/keyboard_popup.xml b/java/res/layout/keyboard_popup.xml index 27388e06b3..c6594f6bf3 100644 --- a/java/res/layout/keyboard_popup.xml +++ b/java/res/layout/keyboard_popup.xml @@ -36,6 +36,6 @@ latin:keyBackground="@drawable/btn_keyboard_key_gingerbread_popup" latin:keyHysteresisDistance="0dip" - latin:verticalCorrection="-20dip" + latin:verticalCorrection="@dimen/mini_keyboard_vertical_correction" /> </LinearLayout> diff --git a/java/res/values-land/dimens.xml b/java/res/values-land/dimens.xml index ac0e030d45..1396bff9bc 100644 --- a/java/res/values-land/dimens.xml +++ b/java/res/values-land/dimens.xml @@ -24,6 +24,8 @@ <dimen name="candidate_strip_fading_edge_length">63dip</dimen> <dimen name="spacebar_vertical_correction">2dip</dimen> <!-- Amount of allowance for selecting keys in a mini popup keyboard by sliding finger. --> - <!-- key_height * 1.7 --> + <!-- key_height x 1.7 --> <dimen name="mini_keyboard_slide_allowance">79.9dip</dimen> + <!-- -key_height x 1.0 --> + <dimen name="mini_keyboard_vertical_correction">-47dip</dimen> </resources> diff --git a/java/res/values/dimens.xml b/java/res/values/dimens.xml index b399af489d..502157dcf7 100644 --- a/java/res/values/dimens.xml +++ b/java/res/values/dimens.xml @@ -29,6 +29,8 @@ <dimen name="max_height_for_fullscreen">2.5in</dimen> <dimen name="key_text_size">22sp</dimen> <!-- Amount of allowance for selecting keys in a mini popup keyboard by sliding finger. --> - <!-- key_height * 1.7 --> + <!-- key_height x 1.7 --> <dimen name="mini_keyboard_slide_allowance">91.8dip</dimen> + <!-- -key_height x 1.0 --> + <dimen name="mini_keyboard_vertical_correction">-54dip</dimen> </resources> -- GitLab