diff --git a/java/res/layout/setup_step.xml b/java/res/layout/setup_step.xml index c6462e903a085958acdf8924dff8307a70fa06e0..fa84902bf1e2e405f9a48d33b1d28390b3772b3f 100644 --- a/java/res/layout/setup_step.xml +++ b/java/res/layout/setup_step.xml @@ -25,14 +25,14 @@ <TextView android:id="@+id/setup_step_title" style="@style/setupStepTitleStyle" - android:paddingTop="16dp" - android:paddingBottom="16dp" /> + android:paddingTop="@dimen/setup_step_vertical_padding" + android:paddingBottom="@dimen/setup_step_vertical_padding" /> <TextView android:id="@+id/setup_step_instruction" style="@style/setupStepInstructionStyle" - android:paddingBottom="16dp" /> + android:paddingBottom="@dimen/setup_step_vertical_padding" /> <TextView android:id="@+id/setup_step_action_label" style="@style/setupStepActionLabelStyle" - android:layout_marginTop="2dp" /> + android:layout_marginTop="@dimen/setup_step_horizontal_line_height" /> </LinearLayout> diff --git a/java/res/layout/setup_steps_cards.xml b/java/res/layout/setup_steps_cards.xml index 17207d354d2cfb01d91822a8893316901f8ee358..6c46461feb5d114cab9d26620ecb0c0cea53f03f 100644 --- a/java/res/layout/setup_steps_cards.xml +++ b/java/res/layout/setup_steps_cards.xml @@ -23,7 +23,7 @@ android:id="@+id/setup_step_bullets" android:layout_width="match_parent" android:layout_height="wrap_content" - android:layout_marginTop="16dp" + android:layout_marginTop="@dimen/setup_step_vertical_padding" android:orientation="horizontal"> <TextView android:id="@+id/setup_step1_bullet" @@ -40,8 +40,7 @@ </LinearLayout> <com.android.inputmethod.latin.setup.SetupStepIndicatorView android:id="@+id/setup_step_indicator" - android:layout_width="match_parent" - android:layout_height="24dp" /> + style="@style/setupStepIndicatorStyle" /> <FrameLayout android:id="@+id/setup_steps_pane" android:layout_width="match_parent" @@ -60,5 +59,5 @@ android:id="@+id/setup_finish" android:text="@string/setup_finish_action" style="@style/setupStepActionLabelStyle" - android:layout_marginTop="2dp" /> + android:layout_marginTop="@dimen/setup_step_horizontal_line_height" /> </merge> diff --git a/java/res/layout/setup_welcome_video.xml b/java/res/layout/setup_welcome_video.xml index 3aa4f3ca851f47d1597a2347bedbb820bddacbd5..da59ec883183b6e16301b6e4b2e0cf1fa589a678 100644 --- a/java/res/layout/setup_welcome_video.xml +++ b/java/res/layout/setup_welcome_video.xml @@ -30,8 +30,8 @@ <VideoView android:id="@+id/setup_welcome_video" android:layout_weight="@integer/setup_welcome_video_weight_in_screen" - android:layout_marginTop="24dp" - android:layout_marginBottom="24dp" + android:layout_marginTop="@dimen/setup_welcome_video_vertical_margin" + android:layout_marginBottom="@dimen/setup_welcome_video_vertical_margin" android:layout_width="0dp" android:layout_height="wrap_content" /> <View diff --git a/java/res/layout/setup_wizard.xml b/java/res/layout/setup_wizard.xml index e766e4cbbc53b814055133522c1bc2af2d35dd20..176f836304b32440de93fa3167be5f481ee2479b 100644 --- a/java/res/layout/setup_wizard.xml +++ b/java/res/layout/setup_wizard.xml @@ -24,8 +24,8 @@ android:background="@color/setup_background" android:paddingLeft="@dimen/setup_horizontal_padding" android:paddingRight="@dimen/setup_horizontal_padding" - android:paddingTop="16dp" - android:paddingBottom="16dp"> + android:paddingTop="@dimen/setup_vertical_padding" + android:paddingBottom="@dimen/setup_vertical_padding"> <include android:id="@+id/setup_welcome_screen" layout="@layout/setup_welcome_screen" /> diff --git a/java/res/values/setup-dimens.xml b/java/res/values/setup-dimens.xml index 1634777f99ddfc93941795c2e9f9182b421606f7..dac544029212049641d0f73d122b5489f6cff315 100644 --- a/java/res/values/setup-dimens.xml +++ b/java/res/values/setup-dimens.xml @@ -17,9 +17,21 @@ <resources xmlns:android="http://schemas.android.com/apk/res/android"> <dimen name="setup_title_text_size">46sp</dimen> <dimen name="setup_welcome_description_text_size">26sp</dimen> + <dimen name="setup_step_bullet_text_size">22sp</dimen> + <dimen name="setup_step_indicator_height">24dp</dimen> + <dimen name="setup_step_title_text_size">22sp</dimen> + <dimen name="setup_step_instruction_text_size">14sp</dimen> + <dimen name="setup_step_action_text_size">18sp</dimen> + <dimen name="setup_vertical_padding">16dp</dimen> <dimen name="setup_horizontal_padding">16dp</dimen> + <dimen name="setup_step_action_height">48dp</dimen> + <dimen name="setup_step_horizontal_padding">24dp</dimen> + <dimen name="setup_step_horizontal_padding_half">12dp</dimen> + <dimen name="setup_step_vertical_padding">16dp</dimen> + <dimen name="setup_step_horizontal_line_height">2dp</dimen> <integer name="setup_title_weight_in_screen">40</integer> <integer name="setup_body_weight_in_screen">60</integer> + <dimen name="setup_welcome_video_vertical_margin">24dp</dimen> <integer name="setup_welcome_video_weight_in_screen">80</integer> <integer name="setup_welcome_video_left_padding_weight_in_screen">10</integer> <integer name="setup_welcome_video_right_padding_weight_in_screen">10</integer> diff --git a/java/res/values/setup-styles-common.xml b/java/res/values/setup-styles-common.xml index e9c72eb58f00005865bf7fa58c5a15284a94ea09..f5f59dda8c917076a0c019171b72b9200569617f 100644 --- a/java/res/values/setup-styles-common.xml +++ b/java/res/values/setup-styles-common.xml @@ -24,9 +24,13 @@ <style name="setupWelcomeDescritpionStyle" parent="setupTitleStyle"> <item name="android:textSize">@dimen/setup_welcome_description_text_size</item> </style> + <style name="setupStepIndicatorStyle"> + <item name="android:layout_width">match_parent</item> + <item name="android:layout_height">@dimen/setup_step_indicator_height</item> + </style> <style name="setupStepBulletStyle"> <item name="android:textColor">@color/setup_text_dark</item> - <item name="android:textSize">22sp</item> + <item name="android:textSize">@dimen/setup_step_bullet_text_size</item> <item name="android:layout_width">0dp</item> <item name="android:layout_weight">1.0</item> <item name="android:layout_height">wrap_content</item> @@ -37,32 +41,32 @@ <item name="android:background">@color/setup_step_background</item> <item name="android:layout_width">match_parent</item> <item name="android:layout_height">wrap_content</item> - <item name="android:paddingLeft">24dp</item> - <item name="android:paddingRight">24dp</item> + <item name="android:paddingLeft">@dimen/setup_step_horizontal_padding</item> + <item name="android:paddingRight">@dimen/setup_step_horizontal_padding</item> </style> <style name="setupStepTitleStyle" parent="setupStepBaseStyle"> - <item name="android:textSize">22sp</item> + <item name="android:textSize">@dimen/setup_step_title_text_size</item> </style> <style name="setupStepInstructionStyle" parent="setupStepBaseStyle"> - <item name="android:textSize">14sp</item> + <item name="android:textSize">@dimen/setup_step_instruction_text_size</item> </style> <style name="setupStepStartIndicatorStyle"> <item name="android:layout_width">24dp</item> - <item name="android:layout_height">48dp</item> + <item name="android:layout_height">@dimen/setup_step_action_height</item> </style> <style name="setupStepActionLabelStyleCommon" parent="setupStepBaseStyle"> <item name="android:textColor">@color/setup_step_action_color</item> <item name="android:background">@drawable/setup_step_action_background</item> - <item name="android:layout_height">48dp</item> - <item name="android:paddingLeft">12dp</item> - <item name="android:textSize">18sp</item> - <item name="android:drawablePadding">12dp</item> + <item name="android:layout_height">@dimen/setup_step_action_height</item> + <item name="android:paddingLeft">@dimen/setup_step_horizontal_padding_half</item> + <item name="android:textSize">@dimen/setup_step_action_text_size</item> + <item name="android:drawablePadding">@dimen/setup_step_horizontal_padding_half</item> <item name="android:gravity">center_vertical</item> <item name="android:clickable">true</item> <item name="android:focusable">true</item> </style> <style name="setupStepStartActionLabelStyleCommon" parent="setupStepActionLabelStyleCommon"> - <item name="android:paddingLeft">24dp</item> - <item name="android:paddingRight">24dp</item> + <item name="android:paddingLeft">@dimen/setup_step_horizontal_padding</item> + <item name="android:paddingRight">@dimen/setup_step_horizontal_padding</item> </style> </resources>