From 04573e30ffeebae34785fc3f32dc09c41f7c1c05 Mon Sep 17 00:00:00 2001
From: Yohei Yukawa <yukawa@google.com>
Date: Tue, 13 Nov 2018 13:51:59 -0800
Subject: [PATCH] Bump targetSdkVersion to "28" and minSdkVersion to "21"

With this CL, targetSdkVersion and minSdkVersion will be bumped as
follows:

  targetSdkVersion: 23 -> 28
     minSdkVersion: 14 -> 21

As far as we know, there should be no user-visible behavior change on
supported OS versions.

Fix: 119489995
Test: manually verified that LatinIME still is functional
Change-Id: I68f1545778b0c8b44c6850f22f3f5ca25bdb6de0
---
 build.gradle              | 4 ++--
 java/AndroidManifest.xml  | 2 +-
 tests/AndroidManifest.xml | 2 +-
 3 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/build.gradle b/build.gradle
index ee5b7e6cde..411f8e6479 100644
--- a/build.gradle
+++ b/build.gradle
@@ -24,8 +24,8 @@ android {
     useLibrary 'android.test.mock'
 
     defaultConfig {
-        minSdkVersion 18
-        targetSdkVersion 23
+        minSdkVersion 21
+        targetSdkVersion 28
         versionName "1.0"
 
         applicationId 'com.android.inputmethod.latin'
diff --git a/java/AndroidManifest.xml b/java/AndroidManifest.xml
index 2d0dc4afb5..79d337310a 100644
--- a/java/AndroidManifest.xml
+++ b/java/AndroidManifest.xml
@@ -19,7 +19,7 @@
         package="com.android.inputmethod.latin"
         android:versionCode="28">
 
-    <uses-sdk android:minSdkVersion="14" android:targetSdkVersion="23" />
+    <uses-sdk android:minSdkVersion="21" android:targetSdkVersion="28" />
 
     <uses-permission android:name="android.permission.ACCESS_NETWORK_STATE" />
     <uses-permission android:name="android.permission.DOWNLOAD_WITHOUT_NOTIFICATION" />
diff --git a/tests/AndroidManifest.xml b/tests/AndroidManifest.xml
index aa75ffbd60..125aa10527 100644
--- a/tests/AndroidManifest.xml
+++ b/tests/AndroidManifest.xml
@@ -18,7 +18,7 @@
     package="com.android.inputmethod.latin.tests"
     android:versionCode="28">
 
-    <uses-sdk android:minSdkVersion="14" android:targetSdkVersion="21" />
+    <uses-sdk android:minSdkVersion="21" android:targetSdkVersion="28" />
 
     <uses-permission android:name="android.permission.READ_CONTACTS" />
 
-- 
GitLab